Handle unhandled IsADirectoryError and PermissionError in ZoneInfo #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
requested changes
Aug 18, 2020
Owner
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
As mentioned on the CPython thread, this also needs tests (it will likely also need to be rebased against the master branch).
src/backports/zoneinfo/_common.py
Outdated
| # (e.g. Australia) | ||
| # PermissionError: If the resource_name links to a directory on Windows | ||
| # (e.g. Pacific) | ||
| resource_path = importlib_resources.files(package_name).joinpath(key) |
Owner
There was a problem hiding this comment.
I'm fairly certain this will fail on Python 3.8. I'm not sure why the test suite isn't executing to let you know this, though.
Author
There was a problem hiding this comment.
Seems you're correct here. Not at this time sure of a good alternative to what 3.9 does.
Owner
|
I cannot force push to your branch and something is going on with the CI, so I've forked this in #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to handle a case where directories passed as a key to the ZoneInfo constructor will raise IsADirectoryError or PermissionError depending on OS.
This is achieved by first determining if the specified resource is a directory and raising when applicable.